New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add namespace and name to openshift plan #625

Merged

yaacov merged 1 commit into kubev2v:main from yaacov:add-name-namespace-to-ocp-plan

Jul 27, 2023

Member

yaacov commented Jul 27, 2023 •

edited

Loading

Add namespace and name to openshift plan

Issue:
openshift source requre name and namespace instead of ids in the vms list:

example:

vms:
    - hooks: []
      name: vm-pool-cirros-0
      namespace: defualt
    - hooks: []
      name: vm-pool-cirros-1
      namespace: defualt
    - hooks: []
      name: vm-pool-cirros-2
      namespace: defualt

instead of:

vms:
    - hooks: []
      id: fdagjkdf-ge89723648djkh-fgkadjsgfdfg3u
    - hooks: [][
      name: vm-pool-cirros-1
      id: fdagjkdf-ge89723648djkh-fgkadjsgfdfg3u
    - hooks: [][
      name: vm-pool-cirros-2
      id: fdagjkdf-ge89723648djkh-fgkadjsgfdfg3u


          Add namespace and name to openshift plan

bbdb09f

Signed-off-by: yzamir <[email protected]>

yaacov added the enhancement label

yaacov added this to the 2.5.0 milestone

yaacov requested review from sjd78, sgratch and rszwajko

July 27, 2023 12:43

sonarcloud bot commented Jul 27, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

yaacov merged commit a2fd2f1 into kubev2v:main

5 checks passed

yaacov mentioned this pull request

Reconcile fails with invalid resource name (/) kubev2v/forklift#878

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels